| 1 | From b6da1c2c16cb5e2ca4fb8a39032a04d258f0f719 Mon Sep 17 00:00:00 2001 |
| 2 | From: Matan Breizman <[email protected]> |
| 3 | Date: Thu, 26 Jun 2025 11:04:46 +0300 |
| 4 | Subject: [PATCH] crimson/common/smp_helpers: fix missing include |
| 5 | MIME-Version: 1.0 |
| 6 | Content-Type: text/plain; charset=UTF-8 |
| 7 | Content-Transfer-Encoding: 8bit |
| 8 | |
| 9 | With 550b2b8ade7e10078ab9610442d039b65cce6a2b introducing coroutines in |
| 10 | smp_helpers header, GCC 15 FTBFS with: |
| 11 | ``` |
| 12 | FAILED: src/crimson/CMakeFiles/crimson.dir/net/ProtocolV2.cc.o |
| 13 | In file included from /home/zhscn/project/ceph/src/crimson/net/io_handler.h:11, |
| 14 | from /home/zhscn/project/ceph/src/crimson/net/ProtocolV2.h:9, |
| 15 | from /home/zhscn/project/ceph/src/crimson/net/ProtocolV2.cc:4: |
| 16 | /home/zhscn/project/ceph/src/crimson/common/smp_helpers.h: In function ‘decltype (seastar::futurize_invoke(f)) crimson::invoke_on_all_seq(F)’: |
| 17 | /home/zhscn/project/ceph/src/crimson/common/smp_helpers.h:64:7: error: coroutines require a traits template; cannot find ‘std::coroutine_traits’ [-Wtemplate-body] |
| 18 | 64 | co_await crimson::submit_to(core, [&f] { return seastar::futurize_invoke(f);}); |
| 19 | | ^~~~~~~~ |
| 20 | /home/zhscn/project/ceph/src/crimson/common/smp_helpers.h:64:7: note: perhaps ‘#include <coroutine>’ is missing |
| 21 | ``` |
| 22 | |
| 23 | Signed-off-by: Matan Breizman <[email protected]> |
| 24 | |
| 25 | src/crimson/common/smp_helpers.h | 1 + |
| 26 | 1 file changed, 1 insertion(+) |
| 27 | |
| 28 | diff --git a/src/crimson/common/smp_helpers.h b/src/crimson/common/smp_helpers.h |
| 29 | index 80d56b086ba06..d9e2b61e82ab7 100644 |
| 30 | |
| 31 | |
| 32 | |
| 33 | #include "common/likely.h" |
| 34 | #include "crimson/common/errorator.h" |
| 35 | #include "crimson/common/utility.h" |
| 36 | +#include "crimson/common/coroutine.h" |
| 37 | |
| 38 | namespace crimson { |
| 39 |