Patch-Source: https://github.com/open-telemetry/opentelemetry-cpp/pull/4574 -- From ac9b358898b17a8a7592998745a6bd7e1e267fca Mon Sep 17 00:00:00 2001 From: Om Kulkarni Date: Tue, 15 Sep 2026 20:22:54 +0530 Subject: [PATCH 1/3] [SDK] Add missing cstdint include to predicate_factory.h predicate_factory.h uses uint8_t but does not include cstdint, relying on a transitive include pulled in elsewhere in the translation unit. Building this header on its own fails with newer standard library implementations that no longer provide that transitive include. --- CHANGELOG.md | 6 ++++++ .../opentelemetry/sdk/metrics/view/predicate_factory.h | 1 + 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 608d6079f7..a757dd8d60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,12 @@ Increment the: * [API] Remove regex from trace_state.h [#4570](https://github.com/open-telemetry/opentelemetry-cpp/pull/4570) +* [SDK] Add a missing `` include to `predicate_factory.h`, which + uses `uint8_t` without including the header that declares it. This relied + on a transitive include from elsewhere in the translation unit and failed + to compile standalone on newer standard library implementations. + [#0000](https://github.com/open-telemetry/opentelemetry-cpp/pull/0000) + ## [1.29.0] 2026-09-13 * [RELEASE] Bump main branch to 1.29.0-dev (#4259) diff --git a/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h b/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h index ca7dd4b389..501b69ba93 100644 --- a/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h +++ b/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h @@ -3,6 +3,7 @@ #pragma once +#include #include #include "opentelemetry/nostd/string_view.h" From 8f233af1f787f2b7bfb6c5e2c6ff8495de7a3c19 Mon Sep 17 00:00:00 2001 From: Om Kulkarni Date: Tue, 15 Sep 2026 20:24:05 +0530 Subject: [PATCH 2/3] Update CHANGELOG entry with PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a757dd8d60..0e6cd71517 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,7 @@ Increment the: uses `uint8_t` without including the header that declares it. This relied on a transitive include from elsewhere in the translation unit and failed to compile standalone on newer standard library implementations. - [#0000](https://github.com/open-telemetry/opentelemetry-cpp/pull/0000) + [#4574](https://github.com/open-telemetry/opentelemetry-cpp/pull/4574) ## [1.29.0] 2026-09-13 From bf3bf9802d18b5949405e5c44b2ff41365a06e5f Mon Sep 17 00:00:00 2001 From: Om Kulkarni Date: Wed, 16 Sep 2026 19:10:40 +0530 Subject: [PATCH 3/3] Retrigger CI (Windows vcpkg job appears to have hit an infra timeout, unrelated to this change)