selinux: revert use of __getname() in selinux_genfs_get_sid()

033182ba · Paul Moore <[email protected]> · 2026-05-29 11:24:37 -04:00

Revert commit 54067bacb49c ("selinux: hooks: use __getname() to allocate
path buffer") as it improperly assumed that PATH_MAX == PAGE_SIZE
everywhere.  Moving away from __get_free_page() is still a good thing and
will be revisited in the future.

Cc: Mike Rapoport (Microsoft) <[email protected]>
Reported-by: Venkat Rao Bagalkote <[email protected]>
Signed-off-by: Paul Moore <[email protected]>

Commit: 033182baeab63ce96a6eb8aef1a6cd444fcf9519
Parents: 447e0417

Changes

1 files changed · +2 −2

File	Status	Add	Del	Content
security/selinux/hooks.c	modified	+2	−2	View file

security/selinux/hooks.c

View file

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 95d0fb2..9780196 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1336,7 +1336,7 @@ static int selinux_genfs_get_sid(struct dentry *dentry,
 	struct super_block *sb = dentry->d_sb;
 	char *buffer, *path;
 
-	buffer = __getname();
+	buffer = (char *)__get_free_page(GFP_KERNEL);
 	if (!buffer)
 		return -ENOMEM;
 
@@ -1361,7 +1361,7 @@ static int selinux_genfs_get_sid(struct dentry *dentry,
 			rc = 0;
 		}
 	}
-	__putname(buffer);
+	free_page((unsigned long)buffer);
 	return rc;
 }
 