[PATCH] firmware/dcdbas: fix bug in error cleanup

0968cf51 · Jeff Garzik <[email protected]> · 2006-10-10 02:58:14 -04:00

The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group().  They take the same arguments, so it's easy to
cut-n-paste such a bug.

Signed-off-by: Jeff Garzik <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 0968cf51b6f2ca8a951de4b976370189cf43bbdd
Parents: 15e541fe

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/firmware/dcdbas.c	modified	+1	−1	View file

drivers/firmware/dcdbas.c

View file

diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 339f405..8bcb58c 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev)
 			while (--i >= 0)
 				sysfs_remove_bin_file(&dev->dev.kobj,
 						      dcdbas_bin_attrs[i]);
-			sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
+			sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
 			return error;
 		}
 	}