Fix clear_refs_write() use of struct mm_walk

20cbc972 · Andrew Morton <[email protected]> · 2008-07-05 12:29:05 -07:00

Don't use a static entry, so as to prevent races during concurrent use
of this function.

Reported-by: Alexey Dobriyan <[email protected]>
Cc: Matt Mackall <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 20cbc972617069c1ed434f62151e4de57d26ea46
Parents: fbe08257

Changes

1 files changed · +4 −4

File	Status	Add	Del	Content
fs/proc/task_mmu.c	modified	+4	−4	View file

fs/proc/task_mmu.c

View file

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index ab8ccc9..05053d7 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -476,10 +476,10 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,
 		return -ESRCH;
 	mm = get_task_mm(task);
 	if (mm) {
-		static struct mm_walk clear_refs_walk;
-		memset(&clear_refs_walk, 0, sizeof(clear_refs_walk));
-		clear_refs_walk.pmd_entry = clear_refs_pte_range;
-		clear_refs_walk.mm = mm;
+		struct mm_walk clear_refs_walk = {
+			.pmd_entry = clear_refs_pte_range,
+			.mm = mm,
+		};
 		down_read(&mm->mmap_sem);
 		for (vma = mm->mmap; vma; vma = vma->vm_next) {
 			clear_refs_walk.private = vma;