projects/linux·commit 21155620

crypto: sm2 - Fix crash caused by uninitialized context

21155620 · Tianjia Zhang <[email protected]> · 2023-09-18 16:38:50 +08:00

In sm2_compute_z_digest() function, the newly allocated structure
mpi_ec_ctx is used, but forget to initialize it, which will cause
a crash when performing subsequent operations.

Fixes: e5221fa6a355 ("KEYS: asymmetric: Move sm2 code into x509_public_key")
Cc: [email protected] # v6.5
Signed-off-by: Tianjia Zhang <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
Commit
21155620fbf2edbb071144894ff9d67ba9a1faa0
Parents
0bb80ecc

Changes

1 files changed · +5 −1

FileStatusAddDelContent
crypto/sm2.cmodified+5−1View file

crypto/sm2.c

View file
diff --git a/crypto/sm2.c b/crypto/sm2.c
index 285b3cb..5ab120d 100644
--- a/crypto/sm2.c
+++ b/crypto/sm2.c
@@ -278,10 +278,14 @@ int sm2_compute_z_digest(struct shash_desc *desc,
if (!ec)
return -ENOMEM;
- err = __sm2_set_pub_key(ec, key, keylen);
+ err = sm2_ec_ctx_init(ec);
if (err)
goto out_free_ec;
+ err = __sm2_set_pub_key(ec, key, keylen);
+ if (err)
+ goto out_deinit_ec;
+
bits_len = SM2_DEFAULT_USERID_LEN * 8;
entl[0] = bits_len >> 8;
entl[1] = bits_len & 0xff;