projects/linux·commit 21b56ec4

neo: Remove a bogus NULL check

21b56ec4 · Alan Cox <[email protected]> · 2009-01-11 19:48:34 +00:00

Julia Lawall found an un-needed check in the neo driver. Her patch moves
the check to cover the code dereferencing it, however it cannot be NULL
anyway so remove the NULL check instead.

Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac
Parents
c774bda2

Changes

1 files changed · +0 −3

FileStatusAddDelContent
drivers/serial/jsm/jsm_neo.cmodified+0−3View file

drivers/serial/jsm/jsm_neo.c

View file
diff --git a/drivers/serial/jsm/jsm_neo.c b/drivers/serial/jsm/jsm_neo.c
index b7584ca..e6390d0 100644
--- a/drivers/serial/jsm/jsm_neo.c
+++ b/drivers/serial/jsm/jsm_neo.c
@@ -577,9 +577,6 @@ static void neo_parse_modem(struct jsm_channel *ch, u8 signals)
jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev,
"neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals);
- if (!ch)
- return;
-
/* Scrub off lower bits. They signify delta's, which I don't care about */
/* Keep DDCD and DDSR though */
msignals &= 0xf8;