projects/linux·commit 2aea4fb6

[PATCH] CONFIG_VM_EVENT_COUNTER comment decrustify

2aea4fb6 · Paul Jackson <[email protected]> · 2006-12-22 01:06:10 -08:00

The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS, which provides
VM event counters in /proc/vmstat, has become more essential to
non-EMBEDDED kernel configurations than they were in the past.  Comments in
the code and the Kconfig configuration explanation were stale, downplaying
their role excessively.

Refresh those comments to correctly reflect the current role of VM event
counters.

Signed-off-by: Paul Jackson <[email protected]>
Acked-by: Christoph Lameter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
2aea4fb61609ba7ef82f7dc6fca116bda88816e1
Parents
0b76e20b

Changes

2 files changed · +7 −6

FileStatusAddDelContent
include/linux/vmstat.hmodified+3−2View file
init/Kconfigmodified+4−4View file

include/linux/vmstat.h

View file
diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
index c89df55..5323600 100644
--- a/include/linux/vmstat.h
+++ b/include/linux/vmstat.h
@@ -10,8 +10,9 @@
/*
* Light weight per cpu counter implementation.
*
- * Counters should only be incremented and no critical kernel component
- * should rely on the counter values.
+ * Counters should only be incremented. You need to set EMBEDDED
+ * to disable VM_EVENT_COUNTERS. Things like procps (vmstat,
+ * top, etc) use /proc/vmstat and depend on these counters.
*
* Counters are handled completely inline. On many platforms the code
* generated will simply be the increment of a global address.

init/Kconfig

View file
diff --git a/init/Kconfig b/init/Kconfig
index f000edb..9b1adb1 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -461,10 +461,10 @@ config VM_EVENT_COUNTERS
default y
bool "Enable VM event counters for /proc/vmstat" if EMBEDDED
help
- VM event counters are only needed to for event counts to be
- shown. They have no function for the kernel itself. This
- option allows the disabling of the VM event counters.
- /proc/vmstat will only show page counts.
+ VM event counters are needed for event counts to be shown.
+ This option allows the disabling of the VM event counters
+ on EMBEDDED systems. /proc/vmstat will only show page counts
+ if VM event counters are disabled.
endmenu # General setup