tracing: Don't use out-of-sync va_list in event printing

2ef75e9b · Nikita Yushchenko <[email protected]> · 2021-11-18 17:55:16 +03:00

If trace_seq becomes full, trace_seq_vprintf() no longer consumes
arguments from va_list, making va_list out of sync with format
processing by trace_check_vprintf().

This causes va_arg() in trace_check_vprintf() to return wrong
positional argument, which results into a WARN_ON_ONCE() hit.

ftrace_stress_test from LTP triggers this situation.

Fix it by explicitly avoiding further use if va_list at the point
when it's consistency can no longer be guaranteed.

Link: https://lkml.kernel.org/r/[email protected]

Signed-off-by: Nikita Yushchenko <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>

Commit: 2ef75e9bd2c998f1c6f6f23a3744136105ddefd5
Parents: c4c1dbcc

Changes

1 files changed · +12 −0

File	Status	Add	Del	Content
kernel/trace/trace.c	modified	+12	−0	View file

kernel/trace/trace.c

View file

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index e3c80cf..88de94d 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3812,6 +3812,18 @@ void trace_check_vprintf(struct trace_iterator *iter, const char *fmt,
 		iter->fmt[i] = '\0';
 		trace_seq_vprintf(&iter->seq, iter->fmt, ap);
 
+		/*
+		 * If iter->seq is full, the above call no longer guarantees
+		 * that ap is in sync with fmt processing, and further calls
+		 * to va_arg() can return wrong positional arguments.
+		 *
+		 * Ensure that ap is no longer used in this case.
+		 */
+		if (iter->seq.full) {
+			p = "";
+			break;
+		}
+
 		if (star)
 			len = va_arg(ap, int);
 