projects/linux·commit 347e0899

VMCI: Fix process-to-process DRGAMs.

347e0899 · Andy King <[email protected]> · 2013-03-07 07:29:08 -08:00

When sending between processes, we always schedule a work item.  Our work info
struct has the message embedded in the middle, which means that we end up
overwriting subsequent fields when we copy the (variable-length) message into
it.  Move it to the end of the struct.

Acked-by: Dmitry Torokhov <[email protected]>
Signed-off-by: Andy King <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Commit
347e0899b1c75d907f01ac883ca38d37fe9bfa42
Parents
61ec7e77

Changes

1 files changed · +3 −1

FileStatusAddDelContent
drivers/misc/vmw_vmci/vmci_datagram.cmodified+3−1View file

drivers/misc/vmw_vmci/vmci_datagram.c

View file
diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c b/drivers/misc/vmw_vmci/vmci_datagram.c
index ed5c433..f3cdd90 100644
--- a/drivers/misc/vmw_vmci/vmci_datagram.c
+++ b/drivers/misc/vmw_vmci/vmci_datagram.c
@@ -42,9 +42,11 @@ struct datagram_entry {
struct delayed_datagram_info {
struct datagram_entry *entry;
- struct vmci_datagram msg;
struct work_struct work;
bool in_dg_host_queue;
+ /* msg and msg_payload must be together. */
+ struct vmci_datagram msg;
+ u8 msg_payload[];
};
/* Number of in-flight host->host datagrams */