checkpatch: add check for line continuations in quoted strings

428e2fdc · Joe Perches <[email protected]> · 2011-05-24 17:13:39 -07:00

Add a warning for unterminated quoted strings with line continuations as
these frequently add unwanted whitespace.

Signed-off-by: Joe Perches <[email protected]>
Cc: Andy Whitcroft <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 428e2fdc4ecee2312829e97549f99c12312f4faf
Parents: 5ca43f6c

Changes

1 files changed · +5 −0

File	Status	Add	Del	Content
scripts/checkpatch.pl	modified	+5	−0	View file

scripts/checkpatch.pl

View file

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..5c96729 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2748,6 +2748,11 @@ sub process {
 			WARN("sizeof(& should be avoided\n" . $herecurr);
 		}
 
+# check for line continuations in quoted strings with odd counts of "
+		if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
+			WARN("Avoid line continuations in quoted strings\n" . $herecurr);
+		}
+
 # check for new externs in .c files.
 		if ($realfile =~ /\.c$/ && defined $stat &&
 		    $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)