projects/linux·commit 433ecb4a

fix refrigerator() vs thaw_process() race

433ecb4a · Oleg Nesterov <[email protected]> · 2007-05-06 14:50:40 -07:00

refrigerator() can miss a wakeup, "wait event" loop needs a proper memory
ordering.

Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: "Rafael J. Wysocki" <[email protected]>
Cc: Pavel Machek <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
433ecb4ab312f873870b67ee374502e84f6dcf92
Parents
e87be114

Changes

1 files changed · +4 −2

FileStatusAddDelContent
kernel/power/process.cmodified+4−2View file

kernel/power/process.c

View file
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 6d566bf..0eb5c42 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -47,8 +47,10 @@ void refrigerator(void)
recalc_sigpending(); /* We sent fake signal, clean it up */
spin_unlock_irq(&current->sighand->siglock);
- while (frozen(current)) {
- current->state = TASK_UNINTERRUPTIBLE;
+ for (;;) {
+ set_current_state(TASK_UNINTERRUPTIBLE);
+ if (!frozen(current))
+ break;
schedule();
}
pr_debug("%s left refrigerator\n", current->comm);