cgroup: switch to proc_create()

46ae220b · Li Zefan <[email protected]> · 2008-04-29 01:00:08 -07:00

There is a race between create_proc_entry() and the assignment of file ops.
proc_create() is invented to fix it.

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Paul Menage <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 46ae220bea40bd1cf4abec2d5cdfb4f9396c7115
Parents: 06a11920

Changes

1 files changed · +1 −4

File	Status	Add	Del	Content
kernel/cgroup.c	modified	+1	−4	View file

kernel/cgroup.c

View file

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 97ab04c..436e26f 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2545,7 +2545,6 @@ int __init cgroup_init(void)
 {
 	int err;
 	int i;
-	struct proc_dir_entry *entry;
 
 	err = bdi_init(&cgroup_backing_dev_info);
 	if (err)
@@ -2561,9 +2560,7 @@ int __init cgroup_init(void)
 	if (err < 0)
 		goto out;
 
-	entry = create_proc_entry("cgroups", 0, NULL);
-	if (entry)
-		entry->proc_fops = &proc_cgroupstats_operations;
+	proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);
 
 out:
 	if (err)