projects/linux·commit 4a77c3de

SUNRPC: Fix loop termination condition in gss_free_in_token_pages()

4a77c3de · Chuck Lever <[email protected]> · 2024-06-02 18:15:25 -04:00

The in_token->pages[] array is not NULL terminated. This results in
the following KASAN splat:

  KASAN: maybe wild-memory-access in range [0x04a2013400000008-0x04a201340000000f]

Fixes: bafa6b4d95d9 ("SUNRPC: Fix gss_free_in_token_pages()")
Reviewed-by: Benjamin Coddington <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Commit
4a77c3dead97339478c7422eb07bf4bf63577008
Parents
8d915bbf

Changes

1 files changed · +1 −1

FileStatusAddDelContent
net/sunrpc/auth_gss/svcauth_gss.cmodified+1−1View file

net/sunrpc/auth_gss/svcauth_gss.c

View file
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 96ab50e..73a90ad 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1069,7 +1069,7 @@ static int gss_read_proxy_verf(struct svc_rqst *rqstp,
goto out_denied_free;
pages = DIV_ROUND_UP(inlen, PAGE_SIZE);
- in_token->pages = kcalloc(pages, sizeof(struct page *), GFP_KERNEL);
+ in_token->pages = kcalloc(pages + 1, sizeof(struct page *), GFP_KERNEL);
if (!in_token->pages)
goto out_denied_free;
in_token->page_base = 0;