regmap: rbtree: Fix register default look-up in sync

4b4e9e43 · Lars-Peter Clausen <[email protected]> · 2012-03-23 11:04:57 +01:00

The code currently passes the register offset in the current block to
regcache_lookup_reg. This works fine as long as there is only one block and with
base register of 0, but in all other cases it will look-up the default for a
wrong register, which can cause unnecessary register writes. This patch fixes
it by passing the actual register number to regcache_lookup_reg.

Signed-off-by: Lars-Peter Clausen <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
Cc: <[email protected]>

Commit: 4b4e9e43fd210e0cd2a5d29357e7c000e13e08ae
Parents: dd775ae2

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/base/regmap/regcache-rbtree.c	modified	+1	−1	View file

drivers/base/regmap/regcache-rbtree.c

View file

diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index 5157fa0..fb14a63 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -396,7 +396,7 @@ static int regcache_rbtree_sync(struct regmap *map, unsigned int min,
 							   map->cache_word_size);
 
 			/* Is this the hardware default?  If so skip. */
-			ret = regcache_lookup_reg(map, i);
+			ret = regcache_lookup_reg(map, regtmp);
 			if (ret >= 0 && val == map->reg_defaults[ret].def)
 				continue;
 