projects/linux·commit 4cf65845

Input: cs40l50-vibra - fix potential NULL dereference in cs40l50_upload_owt()

4cf65845 · Yunshui Jiang <[email protected]> · 2025-07-03 21:56:02 -07:00

The cs40l50_upload_owt() function allocates memory via kmalloc()
without checking for allocation failure, which could lead to a
NULL pointer dereference.

Return -ENOMEM in case allocation fails.

Signed-off-by: Yunshui Jiang <[email protected]>
Fixes: c38fe1bb5d21 ("Input: cs40l50 - Add support for the CS40L50 haptic driver")
Link: https://lore.kernel.org/r/[email protected]
Cc: [email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
Commit
4cf65845fdd09d711fc7546d60c9abe010956922
Parents
a106b6a8

Changes

1 files changed · +2 −0

FileStatusAddDelContent
drivers/input/misc/cs40l50-vibra.cmodified+2−0View file

drivers/input/misc/cs40l50-vibra.c

View file
diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c
index dce3b0e..330f091 100644
--- a/drivers/input/misc/cs40l50-vibra.c
+++ b/drivers/input/misc/cs40l50-vibra.c
@@ -238,6 +238,8 @@ static int cs40l50_upload_owt(struct cs40l50_work *work_data)
header.data_words = len / sizeof(u32);
new_owt_effect_data = kmalloc(sizeof(header) + len, GFP_KERNEL);
+ if (!new_owt_effect_data)
+ return -ENOMEM;
memcpy(new_owt_effect_data, &header, sizeof(header));
memcpy(new_owt_effect_data + sizeof(header), work_data->custom_data, len);