tmpfs: fix XATTR N overriding POSIX_ACL Y

4db70f73 · Eric Paris <[email protected]> · 2011-05-25 19:49:18 -07:00

Choosing TMPFS_XATTR default N was switching off TMPFS_POSIX_ACL,
even if it had been Y in oldconfig; and Linus reports that PulseAudio
goes subtly wrong unless it can use ACLs on /dev/shm.

Make TMPFS_POSIX_ACL select TMPFS_XATTR (and depend upon TMPFS),
and move the TMPFS_POSIX_ACL entry before the TMPFS_XATTR entry,
to avoid asking unnecessary questions then ignoring their answers.

Signed-off-by: Hugh Dickins <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 4db70f73e56961b9bcdfd0c36c62847a18b7dbb5
Parents: 520fd845

Changes

1 files changed · +15 −14

File	Status	Add	Del	Content
fs/Kconfig	modified	+15	−14	View file

fs/Kconfig

View file

diff --git a/fs/Kconfig b/fs/Kconfig
index 979992d..f6edba2 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -121,6 +121,20 @@ config TMPFS
 
 	  See <file:Documentation/filesystems/tmpfs.txt> for details.
 
+config TMPFS_POSIX_ACL
+	bool "Tmpfs POSIX Access Control Lists"
+	depends on TMPFS
+	select TMPFS_XATTR
+	select GENERIC_ACL
+	help
+	  POSIX Access Control Lists (ACLs) support permissions for users and
+	  groups beyond the owner/group/world scheme.
+
+	  To learn more about Access Control Lists, visit the POSIX ACLs for
+	  Linux website <http://acl.bestbits.at/>.
+
+	  If you don't know what Access Control Lists are, say N.
+
 config TMPFS_XATTR
 	bool "Tmpfs extended attributes"
 	depends on TMPFS
@@ -133,22 +147,9 @@ config TMPFS_XATTR
 	  Currently this enables support for the trusted.* and
 	  security.* namespaces.
 
-	  If unsure, say N.
-
 	  You need this for POSIX ACL support on tmpfs.
 
-config TMPFS_POSIX_ACL
-	bool "Tmpfs POSIX Access Control Lists"
-	depends on TMPFS_XATTR
-	select GENERIC_ACL
-	help
-	  POSIX Access Control Lists (ACLs) support permissions for users and
-	  groups beyond the owner/group/world scheme.
-
-	  To learn more about Access Control Lists, visit the POSIX ACLs for
-	  Linux website <http://acl.bestbits.at/>.
-
-	  If you don't know what Access Control Lists are, say N.
+	  If unsure, say N.
 
 config HUGETLBFS
 	bool "HugeTLB file system support"