projects/linux·commit 4edbe1d7

dm ioctl: fix out of bounds array access when no devices

4edbe1d7 · Mikulas Patocka <[email protected]> · 2021-03-26 14:32:32 -04:00

If there are not any dm devices, we need to zero the "dev" argument in
the first structure dm_name_list. However, this can cause out of
bounds write, because the "needed" variable is zero and len may be
less than eight.

Fix this bug by reporting DM_BUFFER_FULL_FLAG if the result buffer is
too small to hold the "nl->dev" value.

Signed-off-by: Mikulas Patocka <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Cc: [email protected]
Signed-off-by: Mike Snitzer <[email protected]>
Commit
4edbe1d7bcffcd6269f3b5eb63f710393ff2ec7a
Parents
5424a0b8

Changes

1 files changed · +1 −1

FileStatusAddDelContent
drivers/md/dm-ioctl.cmodified+1−1View file

drivers/md/dm-ioctl.c

View file
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 5e306bb..1ca65b4 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -529,7 +529,7 @@ static int list_devices(struct file *filp, struct dm_ioctl *param, size_t param_
* Grab our output buffer.
*/
nl = orig_nl = get_result_buffer(param, param_size, &len);
- if (len < needed) {
+ if (len < needed || len < sizeof(nl->dev)) {
param->flags |= DM_BUFFER_FULL_FLAG;
goto out;
}