[PATCH] fix audit oops with invalid operator

5422e01a · Amy Griffis <[email protected]> · 2006-08-01 17:52:26 -04:00

Michael C Thompson wrote:  [Tue Aug 01 2006, 02:36:36PM EDT]
> The trigger for this oops is:
> # auditctl -a exit,always -S pread64 -F 'inode<1'

Setting the err value will fix it.

Signed-off-by: Amy Griffis <[email protected]>
Signed-off-by: Al Viro <[email protected]>

Commit: 5422e01ac16df7398b2bad1eccad0ae3be4dee32
Parents: 6988434e

Changes

1 files changed · +2 −0

File	Status	Add	Del	Content
kernel/auditfilter.c	modified	+2	−0	View file

kernel/auditfilter.c

View file

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 5b4e162..32420f9 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -442,6 +442,7 @@ static struct audit_entry *audit_rule_to_entry(struct audit_rule *rule)
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}
@@ -579,6 +580,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}