projects/linux·commit 5577bd8a

SLUB: Do our own flags based on PG_active and PG_error

5577bd8a · Christoph Lameter <[email protected]> · 2007-05-16 22:10:56 -07:00

The atomicity when handling flags in SLUB is not necessary since both flags
used by SLUB are not updated in a racy way.  Flag updates are either done
during slab creation or destruction or under slab_lock.  Some of these flags
do not have the non atomic variants that we need.  So define our own.

Signed-off-by: Christoph Lameter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
5577bd8a85c8b7643a241789b14fafa9c8a6c7db
Parents
eefaca9c

Changes

1 files changed · +14 −14

FileStatusAddDelContent
mm/slub.cmodified+14−14View file

mm/slub.c

View file
diff --git a/mm/slub.c b/mm/slub.c
index ce96d48..3ca164f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -99,42 +99,42 @@
* the fast path and disables lockless freelists.
*/
+#define FROZEN (1 << PG_active)
+
+#ifdef CONFIG_SLUB_DEBUG
+#define SLABDEBUG (1 << PG_error)
+#else
+#define SLABDEBUG 0
+#endif
+
static inline int SlabFrozen(struct page *page)
{
- return PageActive(page);
+ return page->flags & FROZEN;
}
static inline void SetSlabFrozen(struct page *page)
{
- SetPageActive(page);
+ page->flags |= FROZEN;
}
static inline void ClearSlabFrozen(struct page *page)
{
- ClearPageActive(page);
+ page->flags &= ~FROZEN;
}
static inline int SlabDebug(struct page *page)
{
-#ifdef CONFIG_SLUB_DEBUG
- return PageError(page);
-#else
- return 0;
-#endif
+ return page->flags & SLABDEBUG;
}
static inline void SetSlabDebug(struct page *page)
{
-#ifdef CONFIG_SLUB_DEBUG
- SetPageError(page);
-#endif
+ page->flags |= SLABDEBUG;
}
static inline void ClearSlabDebug(struct page *page)
{
-#ifdef CONFIG_SLUB_DEBUG
- ClearPageError(page);
-#endif
+ page->flags &= ~SLABDEBUG;
}
/*