[PATCH] nsproxy cloning error path fix
5d124e99 · Pavel <[email protected]> · 2006-10-02 02:18:24 -07:00
This patch fixes copy_namespaces()'s error path.
when new nsproxy (new_ns) is created pointers to namespaces (ipc, uts) are
copied from the old nsproxy. Later in copy_utsname, copy_ipcs, etc.
according namespaces are get-ed. On error path needed namespaces are
put-ed, so there's no need to put new nsproxy itelf as it woud cause
putting namespaces for the second time.
Found when incorporating namespaces into OpenVZ kernel.
Signed-off-by: Pavel Emelianov <[email protected]>
Acked-by: Serge Hallyn <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
- Commit
- 5d124e99c2fee1c8f3020ecb0dff8d5617ee7991
- Parents
- fcfbd547
Changes
1 files changed · +1 −1
diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
index 8d6c852..6ebdb82 100644
--- a/kernel/nsproxy.c
+++ b/kernel/nsproxy.c
@@ -123,7 +123,7 @@ out_uts:
put_namespace(new_ns->namespace);
out_ns:
tsk->nsproxy = old_ns;
- put_nsproxy(new_ns);
+ kfree(new_ns);
goto out;
}