pinctrl: mediatek: fix dual-edge code defect

5edf673d · hongkun.cao <[email protected]> · 2016-05-21 15:23:39 +08:00

When a dual-edge irq is triggered, an incorrect irq will be reported on
condition that the external signal is not stable and this incorrect irq
has been registered.
Correct the register offset.

Cc: [email protected]
Signed-off-by: Hongkun Cao <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>

Commit: 5edf673d07fdcb6498be24914f3f38f8d8843199
Parents: 9feeed94

Changes

1 files changed · +3 −2

File	Status	Add	Del	Content
drivers/pinctrl/mediatek/pinctrl-mtk-common.c	modified	+3	−2	View file

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

View file

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 207b13b..a607655 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -1256,9 +1256,10 @@ static void mtk_eint_irq_handler(struct irq_desc *desc)
 	const struct mtk_desc_pin *pin;
 
 	chained_irq_enter(chip, desc);
-	for (eint_num = 0; eint_num < pctl->devdata->ap_num; eint_num += 32) {
+	for (eint_num = 0;
+	     eint_num < pctl->devdata->ap_num;
+	     eint_num += 32, reg += 4) {
 		status = readl(reg);
-		reg += 4;
 		while (status) {
 			offset = __ffs(status);
 			index = eint_num + offset;