lockdep: make cli/sti annotation warnings clearer

5f9fa8a6 · Ingo Molnar <[email protected]> · 2007-12-07 19:02:47 +01:00

make cli/sti annotation warnings easier to interpret.

Signed-off-by: Ingo Molnar <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>

Commit: 5f9fa8a62d6a98f5cb2ee2e00b85bfe95e45888d
Parents: f194d132

Changes

1 files changed · +9 −4

File	Status	Add	Del	Content
kernel/lockdep.c	modified	+9	−4	View file

kernel/lockdep.c

View file

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 0f38962..723bd9f 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2654,10 +2654,15 @@ static void check_flags(unsigned long flags)
 	if (!debug_locks)
 		return;
 
-	if (irqs_disabled_flags(flags))
-		DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled);
-	else
-		DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled);
+	if (irqs_disabled_flags(flags)) {
+		if (DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)) {
+			printk("possible reason: unannotated irqs-off.\n");
+		}
+	} else {
+		if (DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled)) {
+			printk("possible reason: unannotated irqs-on.\n");
+		}
+	}
 
 	/*
 	 * We dont accurately track softirq state in e.g.