[PATCH] fbdev: Initialize var structure in calc_mode_timings

61ab7903 · Antonino A. Daplas <[email protected]> · 2005-09-09 13:10:02 -07:00

The var structure in calc_mode_timings is not properly initialized (zero set)
which leads to undefined behavior when it is passed to fb_get_mode().

Signed-off-by: Antonino Daplas <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 61ab7903b8cd772d3bfb28bc26d02c599cfb0e5b
Parents: 7c1cd6fd

Changes

1 files changed · +3 −1

File	Status	Add	Del	Content
drivers/video/fbmon.c	modified	+3	−1	View file

drivers/video/fbmon.c

View file

diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index 791bec3..713226c 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -314,11 +314,13 @@ static int edid_is_monitor_block(unsigned char *block)
 		return 0;
 }
 
-static void calc_mode_timings(int xres, int yres, int refresh, struct fb_videomode *mode)
+static void calc_mode_timings(int xres, int yres, int refresh,
+			      struct fb_videomode *mode)
 {
 	struct fb_var_screeninfo var;
 	struct fb_info info;
 	
+	memset(&var, 0, sizeof(struct fb_var_screeninfo));
 	var.xres = xres;
 	var.yres = yres;
 	fb_get_mode(FB_VSYNCTIMINGS | FB_IGNOREMON, 