gpio/rockchip: fix refcount leak in rockchip_gpiolib_register()

63ff545a · Wang Yufen <[email protected]> · 2022-12-05 14:19:56 +08:00

The node returned by of_get_parent() with refcount incremented,
of_node_put() needs be called when finish using it. So add it in the
end of of_pinctrl_get().

Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: Wang Yufen <[email protected]>
Signed-off-by: Bartosz Golaszewski <[email protected]>

Commit: 63ff545af73f759d1bd04198af8ed8577fb739fc
Parents: 45fecdb9

Changes

1 files changed · +1 −0

File	Status	Add	Del	Content
drivers/gpio/gpio-rockchip.c	modified	+1	−0	View file

drivers/gpio/gpio-rockchip.c

View file

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 870910b..200e43a 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -610,6 +610,7 @@ static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank)
 			return -ENODATA;
 
 		pctldev = of_pinctrl_get(pctlnp);
+		of_node_put(pctlnp);
 		if (!pctldev)
 			return -ENODEV;
 