projects/linux·commit 6dd6bca3

mmc: sd: clean up redundant memset

6dd6bca3 · Mark Asselstine <[email protected]> · 2010-05-26 14:41:58 -07:00

The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and there is
another clearing of mrq just below.  We remove the first memset since if
the initial tests in the for loop fail the memset is not required.

Signed-off-by: Mark Asselstine <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
6dd6bca3fb6d4f186cdc67ba9e3949ef456dcc53
Parents
bbce5802

Changes

1 files changed · +0 −2

FileStatusAddDelContent
drivers/mmc/core/sd_ops.cmodified+0−2View file

drivers/mmc/core/sd_ops.c

View file
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 0d96080..63772e7 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
* we cannot use the retries field in mmc_command.
*/
for (i = 0;i <= retries;i++) {
- memset(&mrq, 0, sizeof(struct mmc_request));
-
err = mmc_app_cmd(host, card);
if (err) {
/* no point in retrying; no APP commands allowed */