Disable SLUB_TINY for build testing

6f110a5e · Linus Torvalds <[email protected]> · 2025-04-06 10:00:04 -07:00

... and don't error out so hard on missing module descriptions.

Before commit 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()")
we used to warn about missing module descriptions, but only when
building with extra warnigns (ie 'W=1').

After that commit the warning became an unconditional hard error.

And it turns out not all modules have been converted despite the claims
to the contrary.  As reported by Damian Tometzki, the slub KUnit test
didn't have a module description, and apparently nobody ever really
noticed.

The reason nobody noticed seems to be that the slub KUnit tests get
disabled by SLUB_TINY, which also ends up disabling a lot of other code,
both in tests and in slub itself.  And so anybody doing full build tests
didn't actually see this failre.

So let's disable SLUB_TINY for build-only tests, since it clearly ends
up limiting build coverage.  Also turn the missing module descriptions
error back into a warning, but let's keep it around for non-'W=1'
builds.

Reported-by: Damian Tometzki <[email protected]>
Link: https://lore.kernel.org/all/01070196099fd059-e8463438-7b1b-4ec8-816d-173874be9966-000000@eu-central-1.amazonses.com/
Cc: Masahiro Yamada <[email protected]>
Cc: Jeff Johnson <[email protected]>
Fixes: 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()")
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 6f110a5e4f9977c31ce76fefbfef6fd4eab6bfb7
Parents: 16cd1c26

Changes

2 files changed · +2 −2

File	Status	Add	Del	Content
mm/Kconfig	modified	+1	−1	View file
scripts/mod/modpost.c	modified	+1	−1	View file

mm/Kconfig

View file

diff --git a/mm/Kconfig b/mm/Kconfig
index d3fb376..e113f71 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -201,7 +201,7 @@ config KVFREE_RCU_BATCHED
 
 config SLUB_TINY
 	bool "Configure for minimal memory footprint"
-	depends on EXPERT
+	depends on EXPERT && !COMPILE_TEST
 	select SLAB_MERGE_DEFAULT
 	help
 	   Configures the slab allocator in a way to achieve minimal memory

scripts/mod/modpost.c

View file

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 92627e8..be89921 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1603,7 +1603,7 @@ static void read_symbols(const char *modname)
 		}
 
 		if (!get_modinfo(&info, "description"))
-			error("missing MODULE_DESCRIPTION() in %s\n", modname);
+			warn("missing MODULE_DESCRIPTION() in %s\n", modname);
 	}
 
 	for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {