projects/linux·commit 73aea4ec

[PATCH] nfsd4: fix setclientid unlock of unlocked state lock

73aea4ec · Neil Brown <[email protected]> · 2005-09-13 01:25:39 -07:00

We could try to unlock the state lock here without having first locked it.

Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Neil Brown <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
73aea4ecd38ebeff9e322f738057f4ae2c32a3ee
Parents
b59e3c0e

Changes

1 files changed · +2 −3

FileStatusAddDelContent
fs/nfsd/nfs4state.cmodified+2−3View file

fs/nfsd/nfs4state.c

View file
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index ec2fdb0..6bbefd0 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -678,13 +678,12 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_setclientid *setclid)
int status;
char dname[HEXDIR_LEN];
- status = nfserr_inval;
if (!check_name(clname))
- goto out;
+ return nfserr_inval;
status = nfs4_make_rec_clidname(dname, &clname);
if (status)
- goto out;
+ return status;
/*
* XXX The Duplicate Request Cache (DRC) has been checked (??)