projects/linux·commit 73ce5934

[PATCH] reiserfs: fix journaling issue regarding fsync()

73ce5934 · Hisashi Hifumi <[email protected]> · 2006-07-10 04:43:56 -07:00

When write() extends a file(i_size is increased) and fsync() is called,
change of inode must be written to journaling area through fsync().
But,currently the i_trans_id is not correctly updated when i_size is
increased.  So fsync() does not kick the journal writer.

Reiserfs_file_write() already updates the transaction when blocks are
allocated, but the case when i_size increases and new blocks are not added
is not correctly treated.

Following patch fix this bug.

Signed-off-by: Hisashi Hifumi <[email protected]>
Cc: Jeff Mahoney <[email protected]>
Cc: Chris Mason <[email protected]>
Cc: Hans Reiser <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
73ce5934e2d855db436566297f12966eb507a435
Parents
0808925e

Changes

1 files changed · +5 −1

FileStatusAddDelContent
fs/reiserfs/file.cmodified+5−1View file

fs/reiserfs/file.c

View file
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c
index 752cea1..f318b58 100644
--- a/fs/reiserfs/file.c
+++ b/fs/reiserfs/file.c
@@ -860,8 +860,12 @@ static int reiserfs_submit_file_region_for_write(struct reiserfs_transaction_han
// this sets the proper flags for O_SYNC to trigger a commit
mark_inode_dirty(inode);
reiserfs_write_unlock(inode->i_sb);
- } else
+ } else {
+ reiserfs_write_lock(inode->i_sb);
+ reiserfs_update_inode_transaction(inode);
mark_inode_dirty(inode);
+ reiserfs_write_unlock(inode->i_sb);
+ }
sd_update = 1;
}