tracing/filters: Fix memory leak when setting a filter

8ad80731 · Li Zefan <[email protected]> · 2009-10-13 09:28:57 +08:00

Every time we set a filter, we leak memory allocated by
postfix_append_operand() and postfix_append_op().

Signed-off-by: Li Zefan <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Tom Zanussi <[email protected]>
Cc: <[email protected]> # for v2.6.31.x
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>

Commit: 8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab
Parents: a813a159

Changes

1 files changed · +2 −1

File	Status	Add	Del	Content
kernel/trace/trace_events_filter.c	modified	+2	−1	View file

kernel/trace/trace_events_filter.c

View file

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 2324578..98a6cc5 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps)
 
 	while (!list_empty(&ps->postfix)) {
 		elt = list_first_entry(&ps->postfix, struct postfix_elt, list);
-		kfree(elt->operand);
 		list_del(&elt->list);
+		kfree(elt->operand);
+		kfree(elt);
 	}
 }
 