fs/exec.c: make do_coredump() void

8cd3ac3a · WANG Cong <[email protected]> · 2009-01-06 14:42:48 -08:00

No one cares do_coredump()'s return value, and also it seems that it
is also not necessary. So make it void.

[[email protected]: coding-style fixes]
Signed-off-by: WANG Cong <[email protected]>
Cc: Alexander Viro <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: 8cd3ac3aca3f2afe8570708066d64d893da468e8
Parents: 4cb0e11b

Changes

2 files changed · +3 −3

File	Status	Add	Del	Content
fs/exec.c	modified	+2	−2	View file
include/linux/binfmts.h	modified	+1	−1	View file

fs/exec.c

View file

diff --git a/fs/exec.c b/fs/exec.c
index 6b09d6f..71a6efe 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1686,7 +1686,7 @@ int get_dumpable(struct mm_struct *mm)
 	return (ret >= 2) ? 2 : ret;
 }
 
-int do_coredump(long signr, int exit_code, struct pt_regs * regs)
+void do_coredump(long signr, int exit_code, struct pt_regs *regs)
 {
 	struct core_state core_state;
 	char corename[CORENAME_MAX_SIZE + 1];
@@ -1842,5 +1842,5 @@ fail_unlock:
 	put_cred(cred);
 	coredump_finish(mm);
 fail:
-	return retval;
+	return;
 }

include/linux/binfmts.h

View file

diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
index 0d0150b..77b4a9e 100644
--- a/include/linux/binfmts.h
+++ b/include/linux/binfmts.h
@@ -107,7 +107,7 @@ extern int setup_arg_pages(struct linux_binprm * bprm,
 extern int bprm_mm_init(struct linux_binprm *bprm);
 extern int copy_strings_kernel(int argc,char ** argv,struct linux_binprm *bprm);
 extern void install_exec_creds(struct linux_binprm *bprm);
-extern int do_coredump(long signr, int exit_code, struct pt_regs * regs);
+extern void do_coredump(long signr, int exit_code, struct pt_regs *regs);
 extern int set_binfmt(struct linux_binfmt *new);
 extern void free_bprm(struct linux_binprm *);
 