projects/linux·commit 8f22757e

[TUN]: Fix leak in tun_get_user()

8f22757e · Dave Jones <[email protected]> · 2006-03-11 18:49:13 -08:00

We're leaking an skb in a failure path in this function.

Coverity #632
Signed-off-by: Dave Jones <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Commit
8f22757ee84da64d4f662f1dd03dae95358a1efe
Parents
53574487

Changes

1 files changed · +4 −1

FileStatusAddDelContent
drivers/net/tun.cmodified+4−1View file

drivers/net/tun.c

View file
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 50b8c67..a1ed2d9 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -249,8 +249,11 @@ static __inline__ ssize_t tun_get_user(struct tun_struct *tun, struct iovec *iv,
if (align)
skb_reserve(skb, align);
- if (memcpy_fromiovec(skb_put(skb, len), iv, len))
+ if (memcpy_fromiovec(skb_put(skb, len), iv, len)) {
+ tun->stats.rx_dropped++;
+ kfree_skb(skb);
return -EFAULT;
+ }
skb->dev = tun->dev;
switch (tun->flags & TUN_TYPE_MASK) {