projects/linux·commit 90cce03d

wait_for_helper: remove unneeded do_sigaction()

90cce03d · Oleg Nesterov <[email protected]> · 2007-05-09 02:34:36 -07:00

allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction()
prior to.

Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
90cce03d9bfcb28600a56efef6b0a5a4fbf6c2b1
Parents
b8a124da

Changes

1 files changed · +0 −5

FileStatusAddDelContent
kernel/kmod.cmodified+0−5View file

kernel/kmod.c

View file
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 6cea9db..4d32eb0 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -185,14 +185,9 @@ static int wait_for_helper(void *data)
{
struct subprocess_info *sub_info = data;
pid_t pid;
- struct k_sigaction sa;
/* Install a handler: if SIGCLD isn't handled sys_wait4 won't
* populate the status, but will return -ECHILD. */
- sa.sa.sa_handler = SIG_IGN;
- sa.sa.sa_flags = 0;
- siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
- do_sigaction(SIGCHLD, &sa, NULL);
allow_signal(SIGCHLD);
pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD);