V4L/DVB (4289): Missing statement in drivers/media/dvb/frontends/cx22700.c

91a07919 · Eric Sesterhenn <[email protected]> · 2006-06-30 11:51:11 -03:00

Stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear

Signed-off-by: Eric Sesterhenn <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Commit: 91a079196fba6918bdf785533dcdfca5361577cb
Parents: a0fd1cb1

Changes

1 files changed · +1 −0

File	Status	Add	Del	Content
drivers/media/dvb/frontends/cx22700.c	modified	+1	−0	View file

drivers/media/dvb/frontends/cx22700.c

View file

diff --git a/drivers/media/dvb/frontends/cx22700.c b/drivers/media/dvb/frontends/cx22700.c
index 3c7c09a..13ad1bf 100644
--- a/drivers/media/dvb/frontends/cx22700.c
+++ b/drivers/media/dvb/frontends/cx22700.c
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx22700_state *state, struct dvb_ofdm_paramet
 		return -EINVAL;
 
 	if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+		return -EINVAL;
 
 	if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
 		return -EINVAL;