projects/linux·commit 93f1d3e4

remoteproc: stm32: fix building without ARM SMCC

93f1d3e4 · Arnd Bergmann <[email protected]> · 2019-07-08 14:42:51 +02:00

When compile testing this driver without SMCC support enabled,
we get a link error:

drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_start':
stm32_rproc.c:(.text+0x776): undefined reference to `__arm_smccc_smc'
drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_stop':
stm32_rproc.c:(.text+0x92c): undefined reference to `__arm_smccc_smc'

Make the actual call to arm_smccc_smc conditional on the Kconfig
symbol controlling its implementation.

Fixes: 13140de09cc2 ("remoteproc: stm32: add an ST stm32_rproc driver")
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Commit
93f1d3e4b59cf2e7ef31eaf1131480897b040e97
Parents
f1d72c55

Changes

1 files changed · +1 −1

FileStatusAddDelContent
drivers/remoteproc/stm32_rproc.cmodified+1−1View file

drivers/remoteproc/stm32_rproc.c

View file
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index e83077b..e2da719 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -344,7 +344,7 @@ static int stm32_rproc_set_hold_boot(struct rproc *rproc, bool hold)
val = hold ? HOLD_BOOT : RELEASE_BOOT;
- if (ddata->secured_soc) {
+ if (IS_ENABLED(CONFIG_HAVE_ARM_SMCCC) && ddata->secured_soc) {
arm_smccc_smc(STM32_SMC_RCC, STM32_SMC_REG_WRITE,
hold_boot.reg, val, 0, 0, 0, 0, &smc_res);
err = smc_res.a0;