drivers/net/ibmveth.c: memset fix

9dc83afd · Mariusz Kozlowski <[email protected]> · 2007-08-06 23:44:03 +02:00

> >> 	Looks like memset() is zeroing wrong nr of bytes.
> >
> > Good catch, however, I think we can just remove this memset altogether
> > since the memory gets allocated via kzalloc.
>
> Correct, that memset() is superfluous.

Ok. Then this should do it.

Signed-off-by: Mariusz Kozlowski <[email protected]>

 drivers/net/ibmveth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signed-off-by: Jeff Garzik <[email protected]>

Commit: 9dc83afdbefd184bf29f347e8fcbb6d8a2b5e6fe
Parents: 163642a2

Changes

1 files changed · +1 −2

File	Status	Add	Del	Content
drivers/net/ibmveth.c	modified	+1	−2	View file

drivers/net/ibmveth.c

View file

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index cf4a924..acba90f 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_
 {
 	int rc, i;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;
 
 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_
 	SET_MODULE_OWNER(netdev);
 
 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
 	dev->dev.driver_data = netdev;
 
 	adapter->vdev = dev;