[PATCH] module: fix mod_sysfs_setup() return value

a3f99f8b · Akinobu Mita <[email protected]> · 2006-12-29 16:48:20 -08:00

mod_sysfs_setup() doesn't return error when kobject_add_dir() failed.

Signed-off-by: Akinobu Mita <[email protected]>
Cc: Greg KH <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: a3f99f8ba8cbd2d4e231b767b3d6236a555da38c
Parents: 96ceeaf4

Changes

1 files changed · +3 −1

File	Status	Add	Del	Content
kernel/module.c	modified	+3	−1	View file

kernel/module.c

View file

diff --git a/kernel/module.c b/kernel/module.c
index b565eae..dbce132 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module *mod,
 		goto out;
 
 	mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
-	if (!mod->drivers_dir)
+	if (!mod->drivers_dir) {
+		err = -ENOMEM;
 		goto out_unreg;
+	}
 
 	err = module_param_sysfs_setup(mod, kparam, num_params);
 	if (err)