projects/linux·commit b40997b8

um: drivers/xterm.c: fix a file descriptor leak

b40997b8 · Jonathan Neuschäfer <[email protected]> · 2011-09-14 16:21:20 -07:00

I could use out_close1, but that seems to be the code path to close the fd
returned by os_create_unix_socket, and using it to close the fd returned
by mkstemp might lead to some confusion, so I don't do it.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
Signed-off-by: Richard Weinberger <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
b40997b872cdb70140f127af6069f00a86b6cf81
Parents
e5f0bdc7

Changes

1 files changed · +1 −0

FileStatusAddDelContent
arch/um/drivers/xterm.cmodified+1−0View file

arch/um/drivers/xterm.c

View file
diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c
index 8ac7146..2e1de57 100644
--- a/arch/um/drivers/xterm.c
+++ b/arch/um/drivers/xterm.c
@@ -123,6 +123,7 @@ static int xterm_open(int input, int output, int primary, void *d,
err = -errno;
printk(UM_KERN_ERR "xterm_open : unlink failed, errno = %d\n",
errno);
+ close(fd);
return err;
}
close(fd);