[PATCH] sysctl: fix the selinux_sysctl_get_sid

b599fdfd · Eric W. Biederman <[email protected]> · 2007-02-14 00:34:15 -08:00

I goofed and when reenabling the fine grained selinux labels for
sysctls and forgot to add the "/sys" prefix before consulting
the policy database.  When computing the same path using
proc_dir_entries we got the "/sys" for free as it was part
of the tree, but it isn't true for clt_table trees.

Signed-off-by: Eric W. Biederman <[email protected]>
Acked-by: Stephen Smalley <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: b599fdfdb4bb4941e9076308efcf3bb89e577db5
Parents: 3fbfa981

Changes

1 files changed · +6 −0

File	Status	Add	Del	Content
security/selinux/hooks.c	modified	+6	−0	View file

security/selinux/hooks.c

View file

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 118ddfb..b8ede1c 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1451,6 +1451,12 @@ static int selinux_sysctl_get_sid(ctl_table *table, u16 tclass, u32 *sid)
 		path = end;
 		table = table->parent;
 	}
+	buflen -= 4;
+	if (buflen < 0)
+		goto out_free;
+	end -= 4;
+	memcpy(end, "/sys", 4);
+	path = end;
 	rc = security_genfs_sid("proc", path, tclass, sid);
 out_free:
 	free_page((unsigned long)buffer);