xfrm: Fix xfrm_policy_gc_lock handling.

bbb770e7 · Alexey Dobriyan <[email protected]> · 2008-11-03 19:11:29 -08:00

From: Alexey Dobriyan <[email protected]>

Based upon a lockdep trace by Simon Arlott.

xfrm_policy_kill() can be called from both BH and
non-BH contexts, so we have to grab xfrm_policy_gc_lock
with BH disabling.

Signed-off-by: David S. Miller <[email protected]>

Commit: bbb770e7ab9a436752babfc8765e422d7481be1f
Parents: 19ecb6ba

Changes

1 files changed · +2 −2

File	Status	Add	Del	Content
net/xfrm/xfrm_policy.c	modified	+2	−2	View file

net/xfrm/xfrm_policy.c

View file

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 2587274..058f04f 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -315,9 +315,9 @@ static void xfrm_policy_kill(struct xfrm_policy *policy)
 		return;
 	}
 
-	spin_lock(&xfrm_policy_gc_lock);
+	spin_lock_bh(&xfrm_policy_gc_lock);
 	hlist_add_head(&policy->bydst, &xfrm_policy_gc_list);
-	spin_unlock(&xfrm_policy_gc_lock);
+	spin_unlock_bh(&xfrm_policy_gc_lock);
 
 	schedule_work(&xfrm_policy_gc_work);
 }