platform/chrome: cros_usbpd_logger: Add __printf annotation to append_str()

bbb7ad49 · Enric Balletbo i Serra <[email protected]> · 2020-04-14 22:12:39 +02:00

This allows the compiler to verify the format strings vs the types of
the arguments. Also, silence the warning (triggered by W=1):

  cros_usbpd_logger.c:55:2: warning: function ‘append_str’ might be a
  candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Enric Balletbo i Serra <[email protected]>
Signed-off-by: Benson Leung <[email protected]>

Commit: bbb7ad49b8350b79261ce087c8e101d92f15533d
Parents: c032699e

Changes

1 files changed · +1 −0

File	Status	Add	Del	Content
drivers/platform/chrome/cros_usbpd_logger.c	modified	+1	−0	View file

drivers/platform/chrome/cros_usbpd_logger.c

View file

diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index 7de3ea7..d169312 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -46,6 +46,7 @@ static const char * const fault_names[] = {
 	"---", "OCP", "fast OCP", "OVP", "Discharge"
 };
 
+__printf(3, 4)
 static int append_str(char *buf, int pos, const char *fmt, ...)
 {
 	va_list args;