projects/linux·commit bebfef15

UBI: avoid workqueue format string leak

bebfef15 · Kees Cook <[email protected]> · 2014-04-07 21:44:07 -07:00

When building the name for the workqueue thread, make sure a format
string cannot leak in from the disk name.

Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Artem Bityutskiy <[email protected]>
Commit
bebfef150e0b8fa68704cddacf05b8c26462d565
Parents
3d21bb76

Changes

1 files changed · +1 −1

FileStatusAddDelContent
drivers/mtd/ubi/block.cmodified+1−1View file

drivers/mtd/ubi/block.c

View file
diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index 7ff473c..8d659e6 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -431,7 +431,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
* Create one workqueue per volume (per registered block device).
* Rembember workqueues are cheap, they're not threads.
*/
- dev->wq = alloc_workqueue(gd->disk_name, 0, 0);
+ dev->wq = alloc_workqueue("%s", 0, 0, gd->disk_name);
if (!dev->wq)
goto out_free_queue;
INIT_WORK(&dev->work, ubiblock_do_work);