staging: ozwpan: prevent overflow in oz_cdev_write()

c2c65cd2 · Dan Carpenter <[email protected]> · 2013-10-29 22:07:47 +03:00

We need to check "count" so we don't overflow the ei->data buffer.

Reported-by: Nico Golde <[email protected]>
Reported-by: Fabian Yamaguchi <[email protected]>
Signed-off-by: Dan Carpenter <[email protected]>
Cc: [email protected]
Signed-off-by: Linus Torvalds <[email protected]>

Commit: c2c65cd2e14ada6de44cb527e7f1990bede24e15
Parents: 201f99f1

Changes

1 files changed · +3 −0

File	Status	Add	Del	Content
drivers/staging/ozwpan/ozcdev.c	modified	+3	−0	View file

drivers/staging/ozwpan/ozcdev.c

View file

diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 6ccb64f..6ce0af9 100644
--- a/drivers/staging/ozwpan/ozcdev.c
+++ b/drivers/staging/ozwpan/ozcdev.c
@@ -155,6 +155,9 @@ static ssize_t oz_cdev_write(struct file *filp, const char __user *buf,
 	struct oz_app_hdr *app_hdr;
 	struct oz_serial_ctx *ctx;
 
+	if (count > sizeof(ei->data) - sizeof(*elt) - sizeof(*app_hdr))
+		return -EINVAL;
+
 	spin_lock_bh(&g_cdev.lock);
 	pd = g_cdev.active_pd;
 	if (pd)