tracing/eprobe: no need to check for negative ret value for snprintf

c96abaec · Quanfa Fu <[email protected]> · 2023-02-21 08:52:42 +09:00

No need to check for negative return value from snprintf() as the
code does not return negative values.

Link: https://lore.kernel.org/all/[email protected]/

Signed-off-by: Quanfa Fu <[email protected]>
Acked-by: Masami Hiramatsu (Google) <[email protected]>
Reviewed-by: Steven Rostedt (Google) <[email protected]>
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>

Commit: c96abaec78f34366b3ddf1c6be52ca5c1241e15b
Parents: 1fcd09fd

Changes

1 files changed · +4 −8

File	Status	Add	Del	Content
kernel/trace/trace_eprobe.c	modified	+4	−8	View file

kernel/trace/trace_eprobe.c

View file

diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index 352b65e..594ac1d 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -923,17 +923,13 @@ static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const ch
 
 	p = ep->filter_str;
 	for (i = 0; i < argc; i++) {
-		ret = snprintf(p, len, "%s ", argv[i]);
-		if (ret < 0)
-			goto error;
-		if (ret > len) {
-			ret = -E2BIG;
-			goto error;
-		}
+		if (i)
+			ret = snprintf(p, len, " %s", argv[i]);
+		else
+			ret = snprintf(p, len, "%s", argv[i]);
 		p += ret;
 		len -= ret;
 	}
-	p[-1] = '\0';
 
 	/*
 	 * Ensure the filter string can be parsed correctly. Note, this