[PATCH] undo partial cpu_exclusive sched domain disabling

ca2f3daf · Paul Jackson <[email protected]> · 2005-08-25 12:47:50 -07:00

The partial disabling of Dinakar's new facility to allow
cpu_exclusive cpusets to define dynamic sched domains
doesn't go far enough.  At the suggestion of Nick Piggin
and Dinakar, let us instead totally disable this facility
for 2.6.13, in order to avoid problems first reported
by John Hawkes (corrupt sched data structures and kernel oops).

This patch removes the partial disabling code in 2.6.13-rc7,
in anticipation of the next patch, which will totally disable
it instead.

Signed-off-by: Paul Jackson <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: ca2f3daf779f5e89d14e9783fcfd7920842df9e9
Parents: 13142341

Changes

1 files changed · +0 −19

File	Status	Add	Del	Content
kernel/cpuset.c	modified	+0	−19	View file

kernel/cpuset.c

View file

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index d7f4d0c..21a4e3b 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -636,25 +636,6 @@ static void update_cpu_domains(struct cpuset *cur)
 		return;
 
 	/*
-	 * Hack to avoid 2.6.13 partial node dynamic sched domain bug.
-	 * Require the 'cpu_exclusive' cpuset to include all (or none)
-	 * of the CPUs on each node, or return w/o changing sched domains.
-	 * Remove this hack when dynamic sched domains fixed.
-	 */
-	{
-		int i, j;
-
-		for_each_cpu_mask(i, cur->cpus_allowed) {
-			cpumask_t mask = node_to_cpumask(cpu_to_node(i));
-
-			for_each_cpu_mask(j, mask) {
-				if (!cpu_isset(j, cur->cpus_allowed))
-					return;
-			}
-		}
-	}
-
-	/*
 	 * Get all cpus from parent's cpus_allowed not part of exclusive
 	 * children
 	 */