ARM: 7778/1: smp_twd: twd_update_frequency need be run on all online CPUs

cbbe6f82 · Jason Liu <[email protected]> · 2013-07-01 09:53:30 +01:00

When the local timer freq changed, the twd_update_frequency function
should be run all the CPUs include itself, otherwise, the twd freq will
not get updated and the local timer will not run correcttly.

smp_call_function will run functions on all other CPUs, but not include
himself, this is not correct,use on_each_cpu instead to fix this issue.

Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: [email protected]
Acked-by: Linus Walleij <[email protected]>
Acked-by: Shawn Guo <[email protected]>
Signed-off-by: Jason Liu <[email protected]>
Signed-off-by: Russell King <[email protected]>

Commit: cbbe6f82b489e7ceba4ad7c833bd3a76cd0084cb
Parents: fd832478

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
arch/arm/kernel/smp_twd.c	modified	+1	−1	View file

arch/arm/kernel/smp_twd.c

View file

diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 90525d9..f6fd1d4 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block *nb,
 	 * changing cpu.
 	 */
 	if (flags == POST_RATE_CHANGE)
-		smp_call_function(twd_update_frequency,
+		on_each_cpu(twd_update_frequency,
 				  (void *)&cnd->new_rate, 1);
 
 	return NOTIFY_OK;