scsi: smartpqi: unlock on error in pqi_submit_raid_request_synchronous()

cc8f5260 · Dan Carpenter <[email protected]> · 2019-05-29 14:07:39 +03:00

We need to drop the "ctrl_info->sync_request_sem" lock before returning.

Fixes: 6c223761eb54 ("smartpqi: initial commit of Microsemi smartpqi driver")
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Don Brace <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>

Commit: cc8f52609bb4177febade24d11713e20c0893b0a
Parents: 1c90836f

Changes

1 files changed · +4 −2

File	Status	Add	Del	Content
drivers/scsi/smartpqi/smartpqi_init.c	modified	+4	−2	View file

drivers/scsi/smartpqi/smartpqi_init.c

View file

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index d6be4e8..8fd5ffc 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -4046,8 +4046,10 @@ static int pqi_submit_raid_request_synchronous(struct pqi_ctrl_info *ctrl_info,
 				return -ETIMEDOUT;
 			msecs_blocked =
 				jiffies_to_msecs(jiffies - start_jiffies);
-			if (msecs_blocked >= timeout_msecs)
-				return -ETIMEDOUT;
+			if (msecs_blocked >= timeout_msecs) {
+				rc = -ETIMEDOUT;
+				goto out;
+			}
 			timeout_msecs -= msecs_blocked;
 		}
 	}