afs: Fix possible assert with callbacks from yfs servers

cd340703 · Marc Dionne <[email protected]> · 2019-11-21 15:26:15 +00:00

Servers sending callback breaks to the YFS_CM_SERVICE service may
send up to YFSCBMAX (1024) fids in a single RPC.  Anything over
AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger.

Remove the assert, as the count has already been checked against
the appropriate max values in afs_deliver_cb_callback and
afs_deliver_yfs_cb_callback.

Fixes: 35dbfba3111a ("afs: Implement the YFS cache manager service")
Signed-off-by: Marc Dionne <[email protected]>
Signed-off-by: David Howells <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: cd340703c29bdf90f7b32f7eba0ffd6f361b57bb
Parents: cc079039

Changes

1 files changed · +0 −1

File	Status	Add	Del	Content
fs/afs/callback.c	modified	+0	−1	View file

fs/afs/callback.c

View file

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 6cdd704..2dca8df 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count,
 	_enter("%p,%zu,", server, count);
 
 	ASSERT(server != NULL);
-	ASSERTCMP(count, <=, AFSCBMAX);
 
 	/* TODO: Sort the callback break list by volume ID */
 