firmware: dmi: Use the proper accessor for the version field

d2139dfc · Andy Shevchenko <[email protected]> · 2022-07-30 18:28:46 +02:00

The byte at offset 6 represents length. Don't take it and drop it
immediately by using proper accessor, i.e. get_unaligned_be24().

[JD: Change the subject to something less frightening]

Signed-off-by: Andy Shevchenko <[email protected]>
Signed-off-by: Jean Delvare <[email protected]>

Commit: d2139dfca361a1f5bfc4d4a23455b1a409a69cd4
Parents: 4b0986a3

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/firmware/dmi_scan.c	modified	+1	−1	View file

drivers/firmware/dmi_scan.c

View file

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index f191a1f..0eb6b61 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -630,7 +630,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
 {
 	if (memcmp(buf, "_SM3_", 5) == 0 &&
 	    buf[6] < 32 && dmi_checksum(buf, buf[6])) {
-		dmi_ver = get_unaligned_be32(buf + 6) & 0xFFFFFF;
+		dmi_ver = get_unaligned_be24(buf + 7);
 		dmi_num = 0;			/* No longer specified */
 		dmi_len = get_unaligned_le32(buf + 12);
 		dmi_base = get_unaligned_le64(buf + 16);