USB: devio: fix issue with log flooding

d310d05f · Oliver Neukum <[email protected]> · 2014-08-01 09:55:20 +02:00

usbfs allows user space to pass down an URB which sets URB_SHORT_NOT_OK
for output URBs. That causes usbcore to log messages without limit
for a nonsensical disallowed combination. The fix is to silently drop
the attribute in usbfs.
The problem is reported to exist since 3.14
https://www.virtualbox.org/ticket/13085

Signed-off-by: Oliver Neukum <[email protected]>
CC: [email protected]
Acked-by: Alan Stern <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Commit: d310d05f1225d1f6f2bf505255fdf593bfbb3051
Parents: 43508be5

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/usb/core/devio.c	modified	+1	−1	View file

drivers/usb/core/devio.c

View file

diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 257876e..0b59731 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1509,7 +1509,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
 	u = (is_in ? URB_DIR_IN : URB_DIR_OUT);
 	if (uurb->flags & USBDEVFS_URB_ISO_ASAP)
 		u |= URB_ISO_ASAP;
-	if (uurb->flags & USBDEVFS_URB_SHORT_NOT_OK)
+	if (uurb->flags & USBDEVFS_URB_SHORT_NOT_OK && is_in)
 		u |= URB_SHORT_NOT_OK;
 	if (uurb->flags & USBDEVFS_URB_NO_FSBR)
 		u |= URB_NO_FSBR;